-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Support for CapturingTypes #12947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Support for CapturingTypes #12947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9da35a4
to
f66e902
Compare
- Introduce monadic capture set constraint handling - Change CapturingType to take a capture set instead of a single capture reference
Don't allow capture variables to be changed if `<:<` returns false.
Add element validation for capture variables. This can be used to disallow * in instances, or to give better error messages if variable bounds are violated.
# Conflicts: # compiler/src/dotty/tools/dotc/printing/PlainPrinter.scala # tests/neg-custom-args/captures/boxmap.check # tests/neg-custom-args/captures/try.check # tests/neg-custom-args/captures/try2.check
# Conflicts: # compiler/src/dotty/tools/dotc/core/tasty/TreePickler.scala # compiler/src/dotty/tools/dotc/core/tasty/TreeUnpickler.scala # compiler/src/dotty/tools/dotc/printing/RefinedPrinter.scala # tests/pos-custom-args/captures/boxmap.scala # tests/pos-custom-args/captures/cc-expand.scala
Need to strip again after dealiasing
Can be reverted once we assume type variables have by default a {*} Any upper bound.
pruneErasedDef's normalizations interfere with it.
This reverts commit 99d8395.
Superseded by #13309, which is made against cc-experiment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial support for capturing types in the compiler, independent of a particular strategy to test them. This allows us to experiment with the strategy later.
Based on #12938